Conversation
e4d7cab to
cf5df33
Compare
9035afd to
e8e81ce
Compare
|
Rebased onto main to resolve README conflict |
|
I receive: On linux. https://www.electronjs.org/docs/latest/api/system-preferences#systempreferencesgetmediaaccessstatusmediatype-windows-macos |
|
The solution should be different for Wayland 🥲 |
4e86c9c to
3f97ee0
Compare
898b5b2 to
c8aca91
Compare
c8aca91 to
819148b
Compare
9780aef to
6ac7cb6
Compare
This is still the case, otherwise fine by me |
This part is outside Talk Desktop... |
|
I never noticed it in the browser. But seems you are right |
Antreesy
left a comment
There was a problem hiding this comment.
Tested with Linux package, don't have any comments or suggestions. Nice work!
|
On Windows, I am not sure it is related to the PR or setup 🙈 :
and I think there should be a watcher over streams so when a the modal is open and you close a window, the list gets updated. For now, it turns into a black stream but remains there. |
This is Which version of
Also should not be affected by the Talk Desktop...
Nice catch, checking... |
I can reproduce in Web:
I have no idea why it happens |
I cannot reproduce, but after some debugging with @DorraJaouad it seems to be Vue 2.7 + weird v-bind CSS issue. It correctly compiles styles, but it doesn't set CSS variable for "v-bind in css" on the root element of |
113588d to
faf0dad
Compare
Remove preview when the source is not available anymore and request sources each second to check for new sources. cc @DorraJaouad |
DorraJaouad
left a comment
There was a problem hiding this comment.
Tested.
All good 💯 thanks !
Even icons? o_O |
No :( , but it's not related to this PR. |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
faf0dad to
0c1bc9a
Compare







☑️ Resolves
🖼️ Screenshots
Windows / Mac / Linux (xorg)
Windows.mp4
Linux (Wayland)
Wayland with PipeWire has a different workflow:
Linux-Wayland.mp4
🚧 Tasks
app:getDesktopCaptureSourcesmethod to get the list of available sources on backendDesktopMediaSourceDialogwith the list of available sources to share (screens, windows)OCA.Talk.Desktop.getDesktopMediaSourceto invoke the dialog and get the selected sourceOCA.Talk.Desktop.getDesktopMediaSourceinstead of unavailablenavigator.mediaDevices.getDisplayMedia(desktop: add screen sharing support spreed#12003)